New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unreal] bugfix in Quickjs for V8Backend.hpp #1680

Closed

zombieyang wants to merge 1 commit into Tencent:master from zombieyang:temp-2

Contributor

zombieyang commented Mar 22, 2024

使用quickjs时，这个char*没有结尾0导致cpp侧获取的字符串不对。


          [unreal] bugfix in Quickjs for V8Backend.hpp

a728deb

Collaborator

chexiongsheng commented Mar 25, 2024

首先这格式不对。
其次如果v8是有0结尾的话，更合适的方法是改backend-quickjs，backend-quickjs本来就是模拟v8 api。
如果v8是有0结尾，应该它的Utf8Length返回已经包含了0，backend-quickjs应该和这个行为保持一致

zombieyang closed this

chexiongsheng mentioned this pull request

WriteUtf8行为和v8保持一致 puerts/backend-quickjs#14

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet